fix: don't display - placeholder for JS false equivalent types ( eg…

… 0 or [] ) (#6) * fix: don't display `-` placeholder for JS false equivalent types ( eg.: 0 or [] ) * fix: remove joining references * fix: possible infinity calculation
shardeum · May 23, 2024 · aaaf962 · aaaf962
1 parent 968340a
commit aaaf962
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/api/types/node-types.ts b/api/types/node-types.ts
@@ -59,7 +59,6 @@ type NodeNetwork = {
     active: number
     standBy: number
     desired: number
-    joining: number
     syncing: number
   }
   load: {

diff --git a/model/node-network.ts b/model/node-network.ts
@@ -2,7 +2,6 @@ export interface NodeNetwork {
   active: number
   standby: number
   desired: number
-  joining: number
   syncing: number
   load: number
   nodeLoad: {internal: number, external: number}

diff --git a/pages/network/index.tsx b/pages/network/index.tsx
@@ -13,7 +13,7 @@ export default function Network() {
                   <div>Active validators: {nullPlaceholder(network.active)}</div>
                   <div>Standby validators: {nullPlaceholder(network.standby)}</div>
                   <div>Desired network size: {nullPlaceholder(network.desired)}</div>
-                  <div>Joining / Syncing: {nullPlaceholder(network.joining)} / {nullPlaceholder(network.syncing)}</div>
+                  <div>Syncing: {nullPlaceholder(network.syncing)}</div>
               </div>
           </div>
           <div className="flex flex-col items-stretch">
@@ -30,7 +30,7 @@ export default function Network() {
               <h1 className="font-semibold mb-3">Network Health - Coming Soon</h1>
               <div
                   className="bg-white text-stone-500	rounded-xl p-8 text-sm [&>*]:pb-2 flex flex-col flex-grow justify-center">
-                  <div>Current A:S Ratio: {network.active/network.standby * 100}%</div>
+                  <div>Current A:S Ratio: {network.standby > 0 ? network.active/network.standby * 100 : 0}%</div>
                   <div>Target A:S Ratio: {nullPlaceholder(null)}</div>
                   <div>Network health: {nullPlaceholder(null)}%
                   </div>

diff --git a/utils/null-placerholder.ts b/utils/null-placerholder.ts
@@ -1,3 +1,3 @@
 export function nullPlaceholder(value: string | number | null, placeholder = '-') {
-  return value ? value : placeholder;
+  return value != null ? value : placeholder;
 }