Feat: Guild Scheduled Events #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks too bro |
Merged
|
Ready for review/merge |
sgvictorino
reviewed
Jan 27, 2025
| @[JSON::Field(converter: Enum::ValueConverter(Discord::GuildScheduledEvent::EntityType))] | ||
| property entity_type : EntityType | ||
| property entity_id : Snowflake? | ||
| property entity_metadata : EntityMetadata |
There was a problem hiding this comment.
Thank you for working on this! I just noticed voice channel events have null entity_metadata:
Suggested change
| property entity_metadata : EntityMetadata | |
| property entity_metadata : EntityMetadata? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Mappings, API methods, Permissions, Websocket, Caching for the recently released Guild Scheduled Events
Relevant docs are here.
The commits have been separated by each aspect for ease of review.
This has been tested through development, but some bugs could remain as I haven't done a final test of each method and there are no specs.
There are various decisions I made that should be discussed before being merged, like the start time on a newly created event default, the caching code for event users, and perhaps others.
Please reach out in the discord for any small questions, and follow up on the issue on what was discussed, to keep the spam low but the information relevant.