-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for windows/ARM64 #2691
Conversation
Windows/ARM64 is a tier 2 target , hence many features will not supported for it. For more details check out rust platform support, rustlang/rust#52659, rustlang/rust#53621, and rust-lang/rust/compiler/rustc_target/src/spec/mod.rs. |
Thank you for the contribution! We're gonna need CI passing before we can merge this though. |
@Enselic As this PR adds |
There's probably no way we can execute the tests in GitHub CI, because we don't have a ARM64 virtual machine? |
@sharkdp As of now windows ARM64 runner is in prelease in github-actions/runner version 2.309.0 but it is not production ready yet. I found similar issue for |
I would rather not do that. I want a stable CI system. Let's just disable the tests for this platform for now? |
@sharkdp I think they are already disabled (not all but most of). bat/.github/workflows/CICD.yml Lines 239 to 246 in e5c81ed
|
I think this issue is due to wrong version of MS Build Tools ( tauri-apps/wry#410), we can setup right version using |
I don't think anyone knows how to resolve it. Closing for now to keep the PR inbox clean. Of course feel free to re-open if you resume work on this! |
It fixes #2644