Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for windows/ARM64 #2691

Closed
wants to merge 3 commits into from

Conversation

Raghav-Bell
Copy link
Contributor

It fixes #2644

@Raghav-Bell
Copy link
Contributor Author

Raghav-Bell commented Oct 1, 2023

Windows/ARM64 is a tier 2 target , hence many features will not supported for it. For more details check out rust platform support, rustlang/rust#52659, rustlang/rust#53621, and rust-lang/rust/compiler/rustc_target/src/spec/mod.rs.

@Enselic
Copy link
Collaborator

Enselic commented Oct 4, 2023

Thank you for the contribution! We're gonna need CI passing before we can merge this though.

@Raghav-Bell
Copy link
Contributor Author

@Enselic As this PR adds aarch64-pc-windows-msvc target in CI (which is also the only failing target) is tier 2 target for rust (stated above) which doesn't guarantee all test passing. Please help me to resolve error.

@sharkdp
Copy link
Owner

sharkdp commented Oct 4, 2023

There's probably no way we can execute the tests in GitHub CI, because we don't have a ARM64 virtual machine?

@Raghav-Bell
Copy link
Contributor Author

Raghav-Bell commented Oct 4, 2023

@sharkdp As of now windows ARM64 runner is in prelease in github-actions/runner version 2.309.0 but it is not production ready yet. I found similar issue for ring , check it out here : Add support for aarch64-pc-windows-msvc#1614 . We can even try self hosted runner for it as stated here Actions: Self-hosted runners now support Windows ARM64.

@sharkdp
Copy link
Owner

sharkdp commented Oct 5, 2023

We can even try self hosted runner for it as stated here Actions: Self-hosted runners now support Windows ARM64.

I would rather not do that. I want a stable CI system. Let's just disable the tests for this platform for now?

@Raghav-Bell
Copy link
Contributor Author

Raghav-Bell commented Oct 5, 2023

@sharkdp I think they are already disabled (not all but most of).

- name: Set testing options
id: test-options
shell: bash
run: |
# test only library unit tests and binary for arm-type targets
unset CARGO_TEST_OPTIONS
unset CARGO_TEST_OPTIONS ; case ${{ matrix.job.target }} in arm-* | aarch64-*) CARGO_TEST_OPTIONS="--lib --bin ${{ needs.crate_metadata.outputs.name }}" ;; esac;
echo "CARGO_TEST_OPTIONS=${CARGO_TEST_OPTIONS}" >> $GITHUB_OUTPUT

@Raghav-Bell
Copy link
Contributor Author

I think this issue is due to wrong version of MS Build Tools ( tauri-apps/wry#410), we can setup right version using vs-version (setup-msbuild). Please let me know how can we resolve this.

@Enselic
Copy link
Collaborator

Enselic commented Dec 1, 2023

I don't think anyone knows how to resolve it.

Closing for now to keep the PR inbox clean. Of course feel free to re-open if you resume work on this!

@Enselic Enselic closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows ARM64 Build
3 participants