Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add features to support dataverse edmx files, improve performance and maintainability #29

Merged
merged 17 commits into from
Nov 26, 2023

Conversation

FH-Inway
Copy link
Collaborator

This is a pull request for the changes made by @AndrewK2 in #27 and #28 with some additional changes to fix a regression issue. Further information can be found in the reviews of the pull requests as well as issue #24.

The changes address several of the feature needed to fully support Dataverse edmx files. The first post of #24 contains a list of all required features known so far and the ones addressed by these changes.

The changes also include a notable performance improvement by caching regular expressions, see a2db4e9

The changes also include several refactorings to improve the code structure and add some basic unit tests.

@FH-Inway FH-Inway merged commit 2d40144 into shashisadasivan:master Nov 26, 2023
1 check passed
@FH-Inway FH-Inway deleted the fix-pr27-regression branch November 26, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants