GUI tree plotting: no need to set plot/group mode if unchanged

Avoids some double firing of events.
shawnlaffan · Jan 4, 2024 · 3f46a55 · 3f46a55
1 parent e5be430
commit 3f46a55
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/Biodiverse/GUI/Tabs/Clustering.pm b/lib/Biodiverse/GUI/Tabs/Clustering.pm
@@ -341,6 +341,7 @@ sub get_tree_menu_items {
     my $dendro_plot_mode_callback = sub {
         my ($self, $mode_string) = @_;
         $mode_string ||= 'length';
+        return if $self->{plot_mode} eq $mode_string;
         say "[Clustering tab] Changing mode to $mode_string";
         $self->{plot_mode} = $mode_string;
         my $dendrogram = $self->{dendrogram};
@@ -352,6 +353,7 @@ sub get_tree_menu_items {
     my $dendro_select_mode_callback = sub {
         my ($self, $mode_string) = @_;
         $mode_string ||= 'length';
+        return if $self->{group_mode} eq $mode_string;
         say "[Clustering tab] Changing selection mode to $mode_string";
         $self->{group_mode} = $mode_string;
         my $dendrogram = $self->{dendrogram};

diff --git a/lib/Biodiverse/GUI/Tabs/Labels.pm b/lib/Biodiverse/GUI/Tabs/Labels.pm
@@ -330,6 +330,7 @@ sub get_tree_menu_items {
     my $dendro_plot_mode_callback = sub {
         my ($self, $mode_string) = @_;
         $mode_string ||= 'length';
+        return if $self->{plot_mode} eq $mode_string;
         say "[Labels tab] Changing mode to $mode_string";
         $self->{plot_mode} = $mode_string;
         return if !$self->{project}->get_selected_phylogeny;