Index bounds2 #897
Merged
Index bounds2 #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit_interval is a subset of non-negative so needs to be checked first.
This also means we don't need the hard coded bounds.
use Biodiverse::BaseData in get_calculation_metadata so it is not needed in calling code that just wants defaults. And add caching to get_calculations after profiling showed it was a bottleneck.
The current list has been there for several versions and makes startup slower when they are not needed, e.g. in several tests.
Otherwise all calls have to load it, and it is not fast.
This avoids loading some heavy modules when not needed.
Should really move the nbr count checks to a separate method and call it if calculations and nbr_list_count args are passed.
Profiling shows they take about a second or more in total on Windows, and this adds up across >60 tests.
shawnlaffan
force-pushed
the
index_bounds2
branch
from
f9cc027 to
4ec0a1e
Compare
Now that we require tree branches to be non-negative we can be sure the index values are also non-negative.
This was referenced Dec 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several of the issues that motivated #895
Still to do:
canonicalandprettyflags on the JSON structure. Then it can be added to the repo and releases with minimal changes each time indices are updated. (Done in 37ee273)