General changes 20240212 #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes one copy-paste error where the wrong cache name was being used and so the cache was never recovered.
More efficient than passing a default (not that it makes much difference here).
If there is only one valid group then there is no need to attempt any iterations for the curveball or modified independent swaps randomisations.
This saves randomisations transposing the data, only for it to again be transposed inside the add method.
Previously it was only package level settings.
The progress dialogue takes a decent chunk of time under profiling. This is largely because it triggers the main loop which then refreshes the display. The threshold is currently set to one second which should be good enough for most purposes.
No one should really be using this function for research but we might as well make it run in reasonable time.
Gives a slight speedup. Ultimately we will replace these calls with n-at-a-time for loops but that requires a minimum perl version of 5.36.
This allows savings for randomisations that generate many different objects, all with the same set of elements.
It was returning the package cache value. This is the same array but we might as well avoid the cache lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of general optimisations and cleanups.