-
Notifications
You must be signed in to change notification settings - Fork 51
feat/improve layers #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…chitecture and improving skip logic for redundant releases
…e.js 20x compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| sed -i -e "s|arn:aws:lambda:$REGION:[0-9]*:layer:chrome-aws-lambda-arm64:[0-9]*|$ARM64_ARN|g" readme.md | ||
| done | ||
| - name: Commit and Push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README workflow now fails whenever no new release is published
The deploy workflow now exits with code 0 even when the tag is unchanged, so the Update README workflow is triggered on every scheduled run. When there is no new release, the sed commands leave readme.md untouched but this step still executes git commit unconditionally, which exits with a non‑zero status (nothing to commit). That means the README workflow will start failing on every day without a new release. Consider skipping the commit when git diff --quiet shows no changes or short‑circuiting the job based on the skip flag emitted from the deploy workflow.
Useful? React with 👍 / 👎.
|
to better maintain backwards compatibility with existing code, please consider having the x86 version remain named as |
Fix deployment pipeline and add arm64 architecture support
Summary
Fixed three critical issues preventing layer deployments and README updates:
Issues Fixed
Changes Made
.github/workflows/layers_dispatch.yamlchrome-aws-lambda-x64andchrome-aws-lambda-arm64if: steps.latest_release.outputs.skip == 'false'.github/workflows/update_readme.yamlreadme.mdBreaking Changes⚠️
IMPORTANT: Layer names have changed:
chrome-aws-lambdachrome-aws-lambda-x64andchrome-aws-lambda-arm64Existing users will need to update their Lambda functions to use the new layer ARNs. The old
chrome-aws-lambdalayer will no longer receiveupdates.
Testing
Next Deployment
On next workflow run (daily cron or push to master):