Merged
Conversation
This comprehensive update fixes 29 issues across all documentation files: CRITICAL FIXES: - README.md: Update dependencies to match pyproject.toml (pytest 8.0, ruff 0.8) - README.md: Fix linting commands from pylint to ruff - getting_started.md: Fix Signal.create() to use positional arg instead of data= - examples.md: Fix 8 constructor signatures to follow SdlProcess pattern - api_reference.md: Add missing exception documentation to 7 methods IMPORTANT FIXES: - getting_started.md: Soften _done() requirement language - troubleshooting.md: Rewrite _done() section to align with best practices - architecture.md: Clarify handler naming is convention, not enforced - architecture.md: Update event loop pseudocode to match implementation - logging_configuration.md: Fix misleading optimization patterns All code examples now execute correctly and match actual implementation. Documentation is production-ready for PyPI publication. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Convert GitLab CI configuration to GitHub Actions: CI Workflow (.github/workflows/ci.yml): - Ruff formatting check (pysdl/, examples/, tests/) - Ruff linting (pysdl/, examples/, tests/) - mypy type checking (pysdl/, examples/) - pytest with coverage (Python 3.9-3.13 matrix) - Upload coverage to Codecov (Python 3.13 only) - Upload coverage artifacts Publish Workflow (.github/workflows/publish.yml): - Build distribution packages - Publish to PyPI on release (trusted publishing) - Publish to TestPyPI on manual trigger - Uses environment protection and OIDC Features: - Runs on push/PR to main and develop branches - Matrix testing across Python 3.9-3.13 - Pip caching for faster builds - Coverage reporting with artifacts - Retry logic via GitHub Actions defaults Note: .gitlab-ci.yml retained for GitLab compatibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.