sort: do not panic for empty input. #287

shenwei356 · Oct 17, 2024 · cb23c4f · cb23c4f
1 parent f64bcd5
commit cb23c4f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 [![Github Releases (by Release)](https://img.shields.io/github/downloads/shenwei356/csvtk/v0.31.0/total.svg)](https://github.com/shenwei356/csvtk/releases/tag/v0.31.0)
     - `csvtk sort/join`:
         - faster speed and lower memory.
+    - `csvtk sort`:
+        - do not panic for empty input. [#287](https://github.com/shenwei356/csvtk/issues/287)
     - `csvtk summary`:
         - fix the order of columns. [#282](https://github.com/shenwei356/csvtk/issues/282)
     - `csvtk rename2`:

diff --git a/csvtk/cmd/sort.go b/csvtk/cmd/sort.go
@@ -175,7 +175,11 @@ var sortCmd = &cobra.Command{
 		}
 
 		if len(data) == 0 {
-			checkError(fmt.Errorf("no data to sort"))
+			log.Warningf("no data to sort from file: %s", file)
+			if len(headerRow) > 0 && !config.NoOutHeader {
+				checkError(writer.Write(headerRow))
+			}
+			return
 		}
 
 		// checking keys