-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix codementor detection #2593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix codementor detection #2593
Conversation
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Hello @Kavindya-Kariyawasam, Was Codementor the only site changed in data.json? There seems to be quite a large diff. Could you verify it once please ? |
6324434
to
f4622b3
Compare
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
1 similar comment
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Hi @akh7177 , thanks a lot for pointing that out! |
For when the F+ is resolved, there's no need for a dedicated test --- all sites are tested by the validate_targets test module (actually, the same one that's feeding the GitHub Actions comment) poetry run pytest -q --tb no -rA -m validate_targets --chunked-sites "Codementor" The Skipping |
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Hi @ppfeister , |
Hey @Kavindya-Kariyawasam , adding a GET request method seems to solve the issue. Kindly add the below line and lemme know if it fixes it |
aa5339c
to
0e53d78
Compare
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
@Kavindya-Kariyawasam Hm, that's wierd. Can you see check if its working locally? Or is it returning F+/F-? |
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
@akh7177 I reran the Codementor chunk locally with |
poetry run pytest -q --tb no -rA -m validate_targets -n 20 --chunked-sites "Codementor" This reports "2 passed in 4.17s". I also confirmed Codementor still returns 404 on GET for random usernames and 200 for "@blue". The previous CI failure looks like a transient false positive from Codementor; could you kick off another workflow run? Let me know if anything else pops up. |
This PR re-enables Codementor site detection by updating [data.json] and removing it from [removed-sites.md]. Codementor now returns 200 for claimed usernames and 404 for unclaimed ones. However, Sherlock currently does not detect the profile even when it exists (ex: "blue"). Please review the detection logic for this site.