Fixed Instagram false negative #2624
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the use of imginn.com, this pull request successfully removes the false negative of Instagram.
What I changed
Instead of using imginn.com as the probing URL for Instagram, i removed it so Sherlock should scan the instagram.com. Note that I ran this without an Instagram account, showing that most, if not all profiles are visible without the use of imginn.com. This is a fix to the false negative.
Proof it works.
This is the result before the change. I've cut it down to only show the section missing Instagram.
This is the result after the change
As you can see, the change has successfully allowed the detection of NASA's instagram account.