Dev mode: nicer HTML injection of error message / live reload #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the way that build error notifications and the live reload markup is injected. Previously, if there was a build error anywhere on the site, the errors got prepended to the HTML response. This resulted in invalid markup and made the site completely unusable in dev mode. These build errors sometimes happened for relatively minor things, like invalid meta coming back for some items, and may not have a significant impact on the site in a prod build. Instead, this now looks for the </body> tag and injects any HTML there. Rather than spamming all the errors, it just sticks in a nice notification toast that goes away after several seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the way that build error notifications and the live reload markup is injected.
Previously, if there was a build error anywhere on the site, the errors got prepended to the HTML response. This resulted in invalid markup and made the site completely unusable in dev mode.
These build errors sometimes happened for relatively minor things, like invalid meta coming back for some items, and may not have a significant impact on the site in a prod build.
Instead, this now looks for the tag and injects any HTML there.
Rather than spamming all the errors, it just sticks in a nice notification toast that goes away after several seconds.