-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade to node 22 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- @shiftcode/branch-utilities@3.1.1-pr45.0 - @shiftcode/logger@1.1.1-pr45.0 - @shiftcode/publish-helper@3.0.2-pr45.0 - @shiftcode/utilities@3.0.1-pr45.0
# Conflicts: # package-lock.json # packages/publish-helper/package.json
- @shiftcode/branch-utilities@3.1.1-pr45.1 - @shiftcode/logger@1.1.1-pr45.1 - @shiftcode/publish-helper@3.0.2-pr45.1 - @shiftcode/utilities@3.0.1-pr45.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dario-fazio One thing to keep in mind is that whenever a version of an internal package changes that is listed as peerDependency we have to manually update the version range to also include the new pr version but also the one after releasing.
For example in packages/publish-helper/package.json:
"peerDependencies": {
"@shiftcode/branch-utilities": "^3.0.0 || ^3.0.0-pr45",
}The dev dependencies will automatically be updated through lerna.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dario-fazio This is not fully related to the node22 upgrade, but I think we can use this to introduce what we discussed yesterday:
engines definition in the individual packages, I would add node20 & 22 for now, and also update the test step in our CI pipeline to use a matrix to run tests in all supported runtimes. (see here for example)
- @shiftcode/branch-utilities@3.1.1-pr45.2 - @shiftcode/logger@1.1.1-pr45.2 - @shiftcode/publish-helper@3.1.0-pr45.2 - @shiftcode/utilities@3.0.1-pr45.2
|
@dario-fazio Another note, when we have multiple open PRs and one is merged to main and released, we must manually update the base versions in affected packages (see 6341d54) since when merging back to |
BREAKING CHANGE: Requires Node 20 or >=22
- @shiftcode/branch-utilities@4.0.0-pr45.0 - @shiftcode/eslint-config-recommended@4.0.0-pr45.0 - @shiftcode/eslint-plugin-rules@4.0.0-pr45.0 - @shiftcode/logger@2.0.0-pr45.0 - @shiftcode/publish-helper@4.0.0-pr45.0 - @shiftcode/utilities@4.0.0-pr45.0
- @shiftcode/branch-utilities@4.0.0-pr45.1 - @shiftcode/eslint-config-recommended@4.0.0-pr45.1 - @shiftcode/eslint-plugin-rules@4.0.0-pr45.1 - @shiftcode/logger@2.0.0-pr45.1 - @shiftcode/publish-helper@4.0.0-pr45.1 - @shiftcode/utilities@4.0.0-pr45.1
- @shiftcode/branch-utilities@4.0.0-pr45.2 - @shiftcode/eslint-config-recommended@4.0.0-pr45.2 - @shiftcode/eslint-plugin-rules@4.0.0-pr45.2 - @shiftcode/logger@2.0.0-pr45.2 - @shiftcode/publish-helper@4.0.0-pr45.2 - @shiftcode/utilities@4.0.0-pr45.2
No description provided.