Skip to content

Conversation

@dario-fazio
Copy link
Contributor

No description provided.

@dario-fazio dario-fazio linked an issue May 13, 2025 that may be closed by this pull request
dario-fazio and others added 2 commits May 13, 2025 15:08
 - @shiftcode/branch-utilities@3.1.1-pr45.0
 - @shiftcode/logger@1.1.1-pr45.0
 - @shiftcode/publish-helper@3.0.2-pr45.0
 - @shiftcode/utilities@3.0.1-pr45.0
@dario-fazio dario-fazio marked this pull request as ready for review May 13, 2025 13:14
michaelwittwer and others added 2 commits May 14, 2025 08:55
# Conflicts:
#	package-lock.json
#	packages/publish-helper/package.json
 - @shiftcode/branch-utilities@3.1.1-pr45.1
 - @shiftcode/logger@1.1.1-pr45.1
 - @shiftcode/publish-helper@3.0.2-pr45.1
 - @shiftcode/utilities@3.0.1-pr45.1
Copy link
Member

@michaelwittwer michaelwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dario-fazio One thing to keep in mind is that whenever a version of an internal package changes that is listed as peerDependency we have to manually update the version range to also include the new pr version but also the one after releasing.
For example in packages/publish-helper/package.json:

"peerDependencies": {
    "@shiftcode/branch-utilities": "^3.0.0 || ^3.0.0-pr45",
  }

The dev dependencies will automatically be updated through lerna.

Copy link
Member

@michaelwittwer michaelwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dario-fazio This is not fully related to the node22 upgrade, but I think we can use this to introduce what we discussed yesterday:
engines definition in the individual packages, I would add node20 & 22 for now, and also update the test step in our CI pipeline to use a matrix to run tests in all supported runtimes. (see here for example)

michaelwittwer and others added 2 commits May 14, 2025 09:32
 - @shiftcode/branch-utilities@3.1.1-pr45.2
 - @shiftcode/logger@1.1.1-pr45.2
 - @shiftcode/publish-helper@3.1.0-pr45.2
 - @shiftcode/utilities@3.0.1-pr45.2
@michaelwittwer
Copy link
Member

@dario-fazio Another note, when we have multiple open PRs and one is merged to main and released, we must manually update the base versions in affected packages (see 6341d54) since when merging back to main only a graduate of the existing version (removing everything after - in the version) will happen.

dario-fazio and others added 5 commits May 14, 2025 11:14
BREAKING CHANGE:
Requires Node 20 or >=22
 - @shiftcode/branch-utilities@4.0.0-pr45.0
 - @shiftcode/eslint-config-recommended@4.0.0-pr45.0
 - @shiftcode/eslint-plugin-rules@4.0.0-pr45.0
 - @shiftcode/logger@2.0.0-pr45.0
 - @shiftcode/publish-helper@4.0.0-pr45.0
 - @shiftcode/utilities@4.0.0-pr45.0
 - @shiftcode/branch-utilities@4.0.0-pr45.1
 - @shiftcode/eslint-config-recommended@4.0.0-pr45.1
 - @shiftcode/eslint-plugin-rules@4.0.0-pr45.1
 - @shiftcode/logger@2.0.0-pr45.1
 - @shiftcode/publish-helper@4.0.0-pr45.1
 - @shiftcode/utilities@4.0.0-pr45.1
dario-fazio and others added 2 commits May 15, 2025 11:18
 - @shiftcode/branch-utilities@4.0.0-pr45.2
 - @shiftcode/eslint-config-recommended@4.0.0-pr45.2
 - @shiftcode/eslint-plugin-rules@4.0.0-pr45.2
 - @shiftcode/logger@2.0.0-pr45.2
 - @shiftcode/publish-helper@4.0.0-pr45.2
 - @shiftcode/utilities@4.0.0-pr45.2
@dario-fazio dario-fazio merged commit 19c4e29 into main May 15, 2025
3 checks passed
@dario-fazio dario-fazio deleted the #45-upgrade-node branch May 15, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[*] Upgrade to node 22

3 participants