Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Helix editor #1116

Open
wants to merge 37 commits into
base: linux
Choose a base branch
from
Open

Add support for Helix editor #1116

wants to merge 37 commits into from

Conversation

rrojan
Copy link

@rrojan rrojan commented Aug 20, 2024

No associated issue

Description

Screenshots

Release notes

Notes:
None

shiftkey and others added 30 commits August 15, 2024 14:55
…tkey#241)

Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
…iftkey#837 shiftkey#1038)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
…ey#316)

There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
…y#530 shiftkey#561)

* drop old icon used in app window
* regenerate smaller icons from new 256px source
…ration easier (shiftkey#555 shiftkey#558)

Co-Authored-By: nullrequest <30698906+advaithm@users.noreply.github.com>
Co-authored-by: Brendan Forster <github@brendanforster.com>
…y#898)

Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…ftkey#898)

Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
… architectures (shiftkey#898)

Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (shiftkey#898)

Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (shiftkey#898)

Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
shiftkey and others added 7 commits August 15, 2024 14:55
Co-authored-by: Brendan Forster <github@brendanforster.com>
Bumps [electron-packager](https://github.com/electron/electron-packager) from 17.1.1 to 17.1.2.
- [Release notes](https://github.com/electron/electron-packager/releases)
- [Changelog](https://github.com/electron/electron-packager/blob/main/NEWS.md)
- [Commits](electron/packager@v17.1.1...v17.1.2)

---
updated-dependencies:
- dependency-name: electron-packager
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rrojan
Copy link
Author

rrojan commented Aug 22, 2024

@s0me1newithhand7s @shiftkey Should I remove the /usr/bin/env hx part after the recent discussions on #1115

@s0me1newithhand7s
Copy link

@s0me1newithhand7s @shiftkey Should I remove the /usr/bin/env hx part after the recent discussions on #1115

i don't think so, in case my PR got closed you can always drop your commit in git rebase.

Copy link

@s0me1newithhand7s s0me1newithhand7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please?

app/src/lib/editors/linux.ts Outdated Show resolved Hide resolved
@s0me1newithhand7s
Copy link

do git rebase and s all commits into one / d useless commits. and i'll unsub from this PR and wish you luck.

@rrojan
Copy link
Author

rrojan commented Aug 31, 2024

@shiftkey @s0me1newithhand7s - rebased and picked only the first relevant commit here

Copy link

@s0me1newithhand7s s0me1newithhand7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rrojan
Copy link
Author

rrojan commented Sep 27, 2024

@shiftkey Do you need any help here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants