self review + why are there headers in the cmake sources

shih1 · Jan 10, 2025 · dbbb115 · dbbb115
1 parent a0ef915
commit dbbb115
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/surge-fx/CMakeLists.txt b/src/surge-fx/CMakeLists.txt
@@ -56,13 +56,13 @@ juce_add_plugin(${PROJECT_NAME}
 
 target_sources(${PROJECT_NAME} PRIVATE
   SurgeFXEditor.cpp
-  SurgeFXEditor.h
+  # SurgeFXEditor.h
   SurgeFXProcessor.cpp
   ParameterPanel.cpp
-  SurgeFXProcessor.h
-  SurgeLookAndFeel.h
+  # SurgeFXProcessor.h
+  # SurgeLookAndFeel.h
   FXOpenSoundControl.cpp
-  FXOpenSoundControl.h
+  # FXOpenSoundControl.h
   )
 
 target_link_libraries(${PROJECT_NAME} PRIVATE

diff --git a/src/surge-fx/SurgeFXEditor.cpp b/src/surge-fx/SurgeFXEditor.cpp
@@ -238,7 +238,6 @@ void SurgefxAudioProcessorEditor::paint(juce::Graphics &g)
 
 void SurgefxAudioProcessorEditor::resized()
 {
-    // old
     picker->setBounds(100, 10, getWidth() - 200, topSection - 30);
     int ypos0 = topSection - 5;
     int rowHeight = (getHeight() - topSection - 40 - 10) / 6.0;
@@ -253,10 +252,8 @@ void SurgefxAudioProcessorEditor::resized()
         static_cast<int>((static_cast<float>(topSection) / baseHeight) * getHeight());
     int bottomAreaHeight = static_cast<int>((static_cast<float>(40) / baseHeight) * getHeight());
 
-    auto topArea = bounds.removeFromTop(topAreaHeight);
-    auto bottomArea = bounds.removeFromBottom(bottomAreaHeight);
-
-    // picker->setBounds(topArea);
+    bounds.removeFromTop(topAreaHeight);
+    bounds.removeFromBottom(bottomAreaHeight);
 
     fxNameLabel->setFont(juce::FontOptions(28));
     fxNameLabel->setBounds(40, getHeight() - 40, 350, 38);