Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix String#chars #522

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Fix String#chars #522

merged 3 commits into from
Dec 14, 2023

Conversation

yhara
Copy link
Collaborator

@yhara yhara commented Dec 10, 2023 •
edited
Loading

This PR fixes a SEGV occurs by "foo".chars.reverse", for example.

chars is implemented in Rust and calls SkAry::new. I forgot to give appropreate arg for meta_array_new and broken object was created.

@yhara yhara marked this pull request as ready for review December 14, 2023 14:59
@yhara yhara merged commit 010fb2b into main Dec 14, 2023
4 checks passed
@yhara yhara deleted the fix-chars branch December 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yhara