Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add request timeout support #8

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Jun 28, 2024

Addresses concern raised in the issue of the upstream project VVVi/clickhouse-migrations#10

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.94%. Comparing base (8187dba) to head (656d69d).

Files Patch % Lines
src/migrate.ts 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   68.42%   66.94%   -1.48%     
==========================================
  Files           2        2              
  Lines         114      118       +4     
  Branches       20       23       +3     
==========================================
+ Hits           78       79       +1     
+ Misses         36       35       -1     
- Partials        0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i merged commit 12d03a7 into main Jun 28, 2024
3 checks passed
@shini4i shini4i deleted the feat/add-request-timeout-support branch June 28, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants