Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dots in schema names #72

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support dots in schema names #72

wants to merge 4 commits into from

Conversation

milesgranger
Copy link

@milesgranger milesgranger commented Aug 16, 2021

Summary

In #71 it was demonstrated that a schema with a dot . in the name would cause a parsing error. This patch allows supporting this naming style.

Added

  • Support for dot in schema
  • Test for dot in schema name

Changed

  • Update possible chars for schema

Removed

NA

Fixed

NA

File Details

ddlparse.py

Applicable Issues

@milesgranger milesgranger changed the title Support dots in schemas Support dots in schema names Aug 16, 2021
@milesgranger milesgranger marked this pull request as draft August 16, 2021 13:04
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #72 (2067c06) into master (a1cea99) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          391       393    +2     
=========================================
+ Hits           391       393    +2     
Impacted Files Coverage Δ
ddlparse/ddlparse.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1cea99...2067c06. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 17, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 2067c06 on milesgranger:support-dot-schema into a1cea99 on shinichi-takii:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f37d56c on milesgranger:support-dot-schema into a1cea99 on shinichi-takii:master.

@milesgranger milesgranger marked this pull request as ready for review August 17, 2021 07:30
@milesgranger
Copy link
Author

@shinichi-takii ready for review, let me know what you think. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't fail on dot within schema
2 participants