Skip to content

Enhancements: Enhance Tests and Improve CI Workflow#3

Merged
shiningflash merged 4 commits intodevelopfrom
feature/test-enhancements-ci-improvements
Dec 1, 2024
Merged

Enhancements: Enhance Tests and Improve CI Workflow#3
shiningflash merged 4 commits intodevelopfrom
feature/test-enhancements-ci-improvements

Conversation

@shiningflash
Copy link
Owner

Overview

This pull request introduces significant improvements to the testing framework and CI workflow for the project. It ensures comprehensive test coverage and robust CI integration with test coverage reporting.


Key Changes

🧪 Testing Enhancements

  • Enhanced unit, integration, and end-to-end (e2e) testing.
  • Added new e2e tests for contacts and messages features.
  • Refactored existing tests to improve reliability and coverage.
  • Skipped redundant tests and avoided duplication across test types.

CI/CD Improvements

  • Integrated pytest-cov for test coverage reporting.
  • Configured CI to fail if test coverage falls below 80%.
  • Added a step to visualize test coverage in PRs via a coverage report artifact.
  • Fixed warnings related to pytest markers.

Testing Details

  • Verified that all unit, integration, and e2e tests pass successfully.
  • Ensured coverage threshold checks work as expected in CI pipelines.

How to Review

  1. Review the added and refactored test cases in tests/unit/, tests/integration/, and tests/e2e/.
  2. Check the updated CI workflow files (.github/workflows/ci.yml).
  3. Ensure all workflows and test cases are consistent with project requirements.

Additional Notes

  • No breaking changes introduced.

Checklist

  • All tests pass locally and in CI.
  • Test coverage meets the 80% threshold.
  • CI workflow has been updated to include coverage reporting.

Feel free to reach out for any questions or suggestions for further improvements!

Repository owner deleted a comment from codecov-commenter Dec 1, 2024
@github-actions
Copy link

github-actions bot commented Dec 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/sdk
   __init__.py00100% 
   client.py400100% 
   config.py1022 80%
src/sdk/features
   __init__.py00100% 
   contacts.py380100% 
   messages.py260100% 
src/sdk/schemas
   __init__.py00100% 
   contacts.py1811 94%
   messages.py170100% 
src/sdk/utils
   __init__.py00100% 
   exceptions.py5299 83%
   logger.py180100% 
   requests.py1544 73%
   retry.py2111 95%
   validators.py400100% 
TOTAL2951794% 

Tests Skipped Failures Errors Time
51 0 💤 0 ❌ 0 🔥 6.310s ⏱️

@shiningflash shiningflash merged commit e9f26b5 into develop Dec 1, 2024
@shiningflash shiningflash deleted the feature/test-enhancements-ci-improvements branch December 2, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant