-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
20.3.0 SHQ16-2938 option to not modify carrier, SHQ16-2434 add IP to …
…request, SHQ16-2489 handle empty street
- Loading branch information
wsajason
committed
Dec 20, 2017
1 parent
e524b13
commit cd6f9a9
Showing
2 changed files
with
41 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd6f9a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit breaks compatibility with dev-api.shipperhq.com as it does not recognise the ipAddress-field.
cd6f9a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samtroll
We will be updating the dev API - we don't have a specific timescale for this as yet - but in the meantime you can comment out the instance variable for ipAddress around line 44, and the associated getter and setter methods in library-ws/src/Shared/SiteDetails.php