feature: add support for multiple elements highlight#2069
feature: add support for multiple elements highlight#2069IArny wants to merge 0 commit intoshipshapecode:masterfrom
Conversation
|
Also this PR can resolve #525 issue |
|
@rwwagner90 could you review this PR please |
|
@monshan Could you find a time for this PR? |
index.html
Outdated
|
|
||
| <div class="hero-followup font-heading mb-12 mt-12 lg:mb-24 lg:mt-24"> | ||
| <div class="bg-navy inline-block mb-4 w-56 lg:mr-4"> | ||
| <div class=" bg-navy inline-block mb-4 w-56 lg:mr-4"> |
There was a problem hiding this comment.
| <div class=" bg-navy inline-block mb-4 w-56 lg:mr-4"> | |
| <div class="bg-navy inline-block mb-4 w-56 lg:mr-4"> |
landing/js/welcome.js
Outdated
| ], | ||
| id: 'attaching' | ||
| }, | ||
| { |
landing/js/welcome.js
Outdated
| text: 'Your tour steps can highlight multiple elements (like this step).', | ||
| attachTo: { | ||
| element: '.hero-multiple-select', | ||
| on: 'bottom', |
There was a problem hiding this comment.
Lots of weird spacing issues in here. Could you please auto format this with prettier?
| }; | ||
| if (targetElements) { | ||
| const elements = []; | ||
| targetElements.forEach(el => { |
There was a problem hiding this comment.
Spacing issues here as well
|
Thanks for the PR @IArny! Lots of formatting issues with the spacing in this code, please run prettier and clean things up and I will take another look. I think in general we would love to support this feature, but I am not sure if this is the best API for it. |
IArny
force-pushed
the
master
branch
2 times, most recently
from
15bf7d4 to
9a8cbc3
Compare
|
@rwwagner90 thank you for your response. I closed this PR by mistake, but already opened the new one #2083 . I ran prettier and it fixed a little bit more files than were changed by me, hope it's fine. |
2 participants
I would propose feature to support multiple elements highlight. All elements selected with
attachTo.elementwill be highlighted ifattachTo.multipleistrue. I addedmultipleflag toattachTofield to keep old behavior. I'd appreciate your feedback for this PR.