Skip to content

Commit

Permalink
fix(deps): migrate to electron-extension-installer (appium#988)
Browse files Browse the repository at this point in the history
  • Loading branch information
eglitise authored and shiva-guntoju committed Feb 2, 2024
1 parent 537af11 commit 91d1ff9
Show file tree
Hide file tree
Showing 3 changed files with 57 additions and 180 deletions.
5 changes: 2 additions & 3 deletions app/main/debug.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
export async function installExtensions () {
const installer = require('electron-devtools-installer');
const { REACT_DEVELOPER_TOOLS, REDUX_DEVTOOLS } = installer;
const { installExtension, REACT_DEVELOPER_TOOLS, REDUX_DEVTOOLS } = require('electron-extension-installer');
const opts = {
forceDownload: !!process.env.UPGRADE_EXTENSIONS,
loadExtensionOptions: {
allowFileAccess: true
}
};
try {
await installer.default([REACT_DEVELOPER_TOOLS, REDUX_DEVTOOLS], opts);
await installExtension([REACT_DEVELOPER_TOOLS, REDUX_DEVTOOLS], opts);
} catch (e) {
console.warn(`Error installing extension: ${e}`); // eslint-disable-line no-console
}
Expand Down
229 changes: 54 additions & 175 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@
"cross-env": "Maintenance mode",
"devtron": "Abandoned",
"electron": "V14: breaks electron-settings",
"electron-devtools-installer": "Abandoned: replace with electron-extension-installer",
"mocha-multi-reporters": "Appears to be abandoned",
"node-libs-browser": "Deprecated",
"parcel-bundler": "V2: significant rewrite required",
Expand Down Expand Up @@ -212,7 +211,7 @@
"electron": "13.6.9",
"electron-builder": "24.4.0",
"electron-debug": "3.2.0",
"electron-devtools-installer": "3.2.0",
"electron-extension-installer": "1.2.0",
"eslint": "8.45.0",
"eslint-plugin-import": "2.27.5",
"eslint-plugin-jsx-a11y": "6.7.1",
Expand Down

0 comments on commit 91d1ff9

Please sign in to comment.