Skip to content

Commit

Permalink
Merge pull request #17 from 1v/main
Browse files Browse the repository at this point in the history
  • Loading branch information
shkm authored Apr 8, 2024
2 parents f3ed0ed + 65efaaf commit dfd4bf3
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 3 deletions.
7 changes: 4 additions & 3 deletions lib/enummer/extension.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,12 @@ def _enummer_build_values(attribute_name, value_names, options)

define_method("#{method_name}?") { self[attribute_name].include?(name) }
define_method("#{method_name}=") do |new_value|
if new_value
self[attribute_name].push(name)
if ActiveModel::Type::Boolean.new.cast(new_value)
self[attribute_name] += [name]
else
self[attribute_name].delete(name)
self[attribute_name] -= [name]
end
self[attribute_name].uniq!
end
define_method("#{method_name}!") do
update(attribute_name => self[attribute_name] + [name])
Expand Down
20 changes: 20 additions & 0 deletions test/enummer_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,20 @@ def setup
@user3.read = true

assert_equal %i[execute read], @user3.permissions

@user3.save

assert_equal %i[execute read].sort, @user3.permissions.sort
end

test "setting a setter to false removes the value" do
@user1.write = false

assert_equal %i[read execute], @user1.permissions

@user1.save

assert_equal %i[read execute].sort, @user1.permissions.sort
end

test "setting the attribute with strings adds the values" do
Expand All @@ -88,6 +96,18 @@ def setup
refute @user1.consumes_greens?
end

test "update with prefix" do
assert @user1.consumes_cigarettes?
refute @user1.consumes_greens?
@user1.update!(consumes_cigarettes: true)
refute @user1.consumes_greens?
end

test "recognizes boolean params" do
@user1.update!(ActionController::Parameters.new({"consumes_cigarettes"=>"false"}).permit(:consumes_cigarettes))
refute @user1.consumes_cigarettes?
end

test "methods respect _suffix" do
refute @user1.car_transport?
refute @user1.truck_transport?
Expand Down

0 comments on commit dfd4bf3

Please sign in to comment.