Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ValinorConfigFactory and make cuyz/valinor optional #40

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 24, 2024

Shlink is moving into an env-var-based approach for local configs, so options objects are going to be hydrated differently shlinkio/shlink#2224

That makes the ValinorConfigFactory less useful, so this PR marks it as deprecated and makes the cuyz/valinor dependency optional.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (1de7706) to head (bc8af5e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #40   +/-   ##
=========================================
  Coverage     97.80%   97.80%           
  Complexity       19       19           
=========================================
  Files             5        5           
  Lines            91       91           
=========================================
  Hits             89       89           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 0e24fa9 into shlinkio:main Oct 24, 2024
9 checks passed
@acelaya acelaya deleted the feature/deprecate-valinor-factory branch October 24, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant