Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed usages of useEffect #1339

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 14, 2024

No description provided.

Copy link

@acelaya acelaya merged commit c73ece4 into shlinkio:develop Oct 14, 2024
5 checks passed
@acelaya acelaya deleted the feature/avoid-side-effects branch October 14, 2024 16:02
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (94890da) to head (7825f76).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/servers/ManageServers.tsx 45.45% 0 Missing and 6 partials ⚠️
src/servers/helpers/ServerForm.tsx 25.00% 0 Missing and 3 partials ⚠️
src/servers/CreateServer.tsx 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1339      +/-   ##
===========================================
- Coverage    79.13%   79.11%   -0.03%     
===========================================
  Files           49       49              
  Lines         1275     1264      -11     
  Branches       244      242       -2     
===========================================
- Hits          1009     1000       -9     
  Misses          23       23              
+ Partials       243      241       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant