Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove rows #1352

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 19, 2024

Remove references to rows and cols, and use flex utilities to arrange elements positions.

Copy link

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (723e869) to head (9094c1d).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/common/NoMenuLayout.tsx 66.66% 0 Missing and 1 partial ⚠️
src/servers/ManageServers.tsx 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1352   +/-   ##
========================================
  Coverage    79.11%   79.11%           
========================================
  Files           49       49           
  Lines         1264     1264           
  Branches       242      242           
========================================
  Hits          1000     1000           
  Misses          23       23           
  Partials       241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 18d9ed7 into shlinkio:develop Oct 19, 2024
7 checks passed
@acelaya acelaya deleted the feature/remove-rows branch October 19, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant