Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset short URL creation form if saving failed #157

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Dec 9, 2023

Closes #123

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3861683) 79.22% compared to head (9f03202) 79.21%.

Files Patch % Lines
src/short-urls/ShortUrlForm.tsx 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   79.22%   79.21%   -0.01%     
==========================================
  Files         151      151              
  Lines        8693     8695       +2     
  Branches     1092     1093       +1     
==========================================
+ Hits         6887     6888       +1     
  Misses        740      740              
- Partials     1066     1067       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 7439e37 into shlinkio:main Dec 9, 2023
5 of 7 checks passed
@acelaya acelaya deleted the feature/no-reset-form branch December 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not reset short URLs form if an error occurs
1 participant