Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component to collect elements for visits comparison #162

Merged
merged 4 commits into from
Dec 16, 2023

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Dec 16, 2023

Add a <VisitsComparisonCollector /> component that can be used to collect short URLs, tags or domains which visits we want to collect.

The component sticks to the top when scrolling down, making sure it is always visible, and keeps its state even when filtering or paginating the list it is rendered next to.

This PR adds that component to the short URLs list as a proof of concept.

Grabacion.de.pantalla.desde.2023-12-16.09-03-42.webm

Part of #7

@acelaya acelaya force-pushed the feature/visits-collector branch 2 times, most recently from 8f4fe89 to 28d01aa Compare December 16, 2023 09:00
@acelaya acelaya force-pushed the feature/visits-collector branch from 28d01aa to 27efd58 Compare December 16, 2023 11:20
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (85eb4da) 79.27% compared to head (172f5a9) 79.38%.

Files Patch % Lines
src/short-urls/helpers/index.ts 70.37% 0 Missing and 8 partials ⚠️
...ts/visits-comparison/VisitsComparisonCollector.tsx 91.54% 0 Missing and 6 partials ⚠️
...isits/visits-comparison/VisitsComparisonContext.ts 86.48% 0 Missing and 5 partials ⚠️
src/short-urls/helpers/ShortUrlsRowMenu.tsx 85.00% 0 Missing and 3 partials ⚠️
src/visits/visits-comparison/VisitsComparison.tsx 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   79.27%   79.38%   +0.11%     
==========================================
  Files         151      154       +3     
  Lines        8694     8845     +151     
  Branches     1090     1109      +19     
==========================================
+ Hits         6892     7022     +130     
- Misses        739      741       +2     
- Partials     1063     1082      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya marked this pull request as ready for review December 16, 2023 12:50
@acelaya acelaya force-pushed the feature/visits-collector branch from ee25761 to 172f5a9 Compare December 16, 2023 12:51
@acelaya acelaya merged commit b15b897 into shlinkio:main Dec 16, 2023
7 checks passed
@acelaya acelaya deleted the feature/visits-collector branch December 16, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant