Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geolocation redirect conditions #516

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 26, 2024

Closes #515

Allow redirect rules to use geolocation conditions when consuming Shlink 4.3 or newer.

@acelaya acelaya changed the title Feature/geolocation rules Geolocation redirect conditions Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 90.29126% with 30 lines in your changes missing coverage. Please review.

Project coverage is 77.43%. Comparing base (18c27d1) to head (fe86272).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
src/short-urls/ShortUrlsTable.tsx 25.00% 13 Missing and 5 partials ⚠️
src/redirect-rules/helpers/RedirectRuleModal.tsx 73.68% 0 Missing and 10 partials ⚠️
src/redirect-rules/helpers/RedirectRuleCard.tsx 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   78.72%   77.43%   -1.29%     
==========================================
  Files         175      176       +1     
  Lines        7557     7167     -390     
  Branches     1474     1483       +9     
==========================================
- Hits         5949     5550     -399     
  Misses        164      164              
- Partials     1444     1453       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya force-pushed the feature/geolocation-rules branch from 54591c5 to fe86272 Compare November 26, 2024 08:02
@acelaya acelaya merged commit 478679c into shlinkio:main Nov 26, 2024
7 of 8 checks passed
@acelaya acelaya deleted the feature/geolocation-rules branch November 26, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for geolocation redirect rules, when using Shlink 4.3
1 participant