Skip to content

Feature/update sdk #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Feature/update sdk #577

merged 2 commits into from
Jan 27, 2025

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jan 27, 2025

No description provided.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (f2f7899) to head (567c6d7).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   77.35%   79.13%   +1.78%     
==========================================
  Files         177      177              
  Lines        7247     7866     +619     
  Branches     1504     1509       +5     
==========================================
+ Hits         5606     6225     +619     
  Misses        162      162              
  Partials     1479     1479              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya
Copy link
Member Author

acelaya commented Jan 27, 2025

Failing tests in node 22 and 23 are due to a bug in react-router. Merging as they pass in node 20 and the rest of the checks do pass as well.

@acelaya acelaya merged commit 3f2bf2b into shlinkio:main Jan 27, 2025
6 of 8 checks passed
@acelaya acelaya deleted the feature/update-sdk branch January 27, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant