Merge pull request #2306 from acelaya-forks/feature/update-docker-images

Update docker images to Alpine 3.21
shlinkio · Dec 12, 2024 · 55724db · 55724db
2 parents 88c2839 + 9e34183
commit 55724db
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM php:8.4-alpine3.20 AS base
+FROM php:8.4-alpine3.21 AS base
 
 ARG SHLINK_VERSION=latest
 ENV SHLINK_VERSION ${SHLINK_VERSION}

diff --git a/data/infra/php.Dockerfile b/data/infra/php.Dockerfile
@@ -1,4 +1,4 @@
-FROM php:8.4-fpm-alpine3.20
+FROM php:8.4-fpm-alpine3.21
 MAINTAINER Alejandro Celaya <alejandro@alejandrocelaya.com>
 
 ENV APCU_VERSION 5.1.24

diff --git a/data/infra/roadrunner.Dockerfile b/data/infra/roadrunner.Dockerfile
@@ -1,4 +1,4 @@
-FROM php:8.4-alpine3.20
+FROM php:8.4-alpine3.21
 MAINTAINER Alejandro Celaya <alejandro@alejandrocelaya.com>
 
 ENV PDO_SQLSRV_VERSION 5.12.0

diff --git a/module/Core/src/Geolocation/GeolocationDbUpdater.php b/module/Core/src/Geolocation/GeolocationDbUpdater.php
@@ -47,7 +47,7 @@ public function checkDbUpdate(
         }
 
         $lock = $this->locker->createLock(self::LOCK_NAME);
-        $lock->acquire(true); // Block until lock is released
+        $lock->acquire(blocking: true);
 
         try {
             return $this->downloadIfNeeded($downloadProgressHandler);

diff --git a/module/Core/src/ShortUrl/Resolver/PersistenceShortUrlRelationResolver.php b/module/Core/src/ShortUrl/Resolver/PersistenceShortUrlRelationResolver.php
@@ -106,8 +106,8 @@ private function lock(array &$locks, string $name): void
     {
         // Lock dependency creation for up to 5 seconds. This will prevent errors when trying to create the same one
         // more than once in parallel.
-        $locks[$name] = $lock = $this->locker->createLock($name, 5);
-        $lock->acquire(true);
+        $locks[$name] = $lock = $this->locker->createLock($name, ttl: 5);
+        $lock->acquire(blocking: true);
     }
 
     /**