Feature/slug url chars #1911
Merged
Feature/slug url chars #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1911 +/- ##
=============================================
+ Coverage 96.73% 96.74% +0.01%
- Complexity 1306 1313 +7
=============================================
Files 244 245 +1
Lines 4530 4551 +21
=============================================
+ Hits 4382 4403 +21
Misses 148 148
☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
feature/slug-url-chars
branch
from
61a4e1b to
e431395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1901
This PR adds validation to custom slugs to make sure URL-reserved characters are not allowed.
Not allowed characters are the ones specified in RFC-3986, with the only exception that, if multi-segment slugs are enabled, then the
/character is allowed.