Allow QR code logo to be individually disabled #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
feature/qr-disable-logo
branch
from
a0971e9 to
1a44108
Compare
acelaya
force-pushed
the
feature/qr-disable-logo
branch
from
1a44108 to
6ad8b03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2313 +/- ##
==========================================
Coverage 93.71% 93.71%
- Complexity 1680 1682 +2
==========================================
Files 276 276
Lines 5839 5840 +1
==========================================
+ Hits 5472 5473 +1
Misses 367 367 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2229
Add a new
logoparameter to the QR code URL that can be used to disable the globally configured logo.The param is
logo=disableso that it can be used in future to, for example, dynamically select from multiple logos, but for now it only accepts thedisabledvalue and is ignored if any other value is provided.