Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get back docker image building for ARM architecture #2347

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jan 29, 2025

Closes #2346

Enable docker image building for ARM architectures

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (e9fe1ac) to head (193be55).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2347   +/-   ##
==========================================
  Coverage      93.77%   93.77%           
  Complexity      1702     1702           
==========================================
  Files            276      276           
  Lines           5895     5895           
==========================================
  Hits            5528     5528           
  Misses           367      367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya
Copy link
Member Author

acelaya commented Jan 29, 2025

I disabled temporarily the restriction to build docker image during CI only if the Dockerfile changed, and could verify the workaround described in docker/setup-qemu-action#188 (comment) works. See https://github.com/shlinkio/shlink/actions/runs/13029520862/job/36345486359?pr=2347

@acelaya acelaya force-pushed the feature/docker-arm branch from 3f01c17 to 193be55 Compare January 29, 2025 10:59
@acelaya acelaya merged commit 0ddfcb7 into shlinkio:develop Jan 29, 2025
23 checks passed
@acelaya acelaya deleted the feature/docker-arm branch January 29, 2025 11:02
@theofficialgman
Copy link

theofficialgman commented Jan 30, 2025

@acelaya github actions made ARM64 Linux runners free and available for open source repositories recently (2 weeks ago https://github.com/orgs/community/discussions/19197#discussioncomment-11859757). No need to use QEMU if you switch to these native ARM64 runners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build docker image for ARM arch again
2 participants