Support for finding fortune files from XDG_DATA_DIRS

[ralismark]

Resolves #74.

This reworks support for FORTDIR/OFFDIR and LOCFORTDIR/LOCOFFDIR to support any amount of directories. I've also refactored the fortune file lookup logic to be more sensible.

---

My intention for the new lookup logic is as follows:

• If the name starts with / or ./ or ../, then treat it as absolute/relative to current directory. Don't do any further processing.
• If the name ends with -o, strip that suffix and look in offensive dirs instead of regular fortune dirs. This matches the BSD-compatibility feature.
• For each fortune directory <fortdir> (out of paths in $XDG_DATA_DIR, FORTDIR, and LOCFORTDIR, or the corresponding offensive dirs):
  • For each language <lang>, try <fortdir>/<lang>/<name>, then try <fortdir>/<name>
  • Take the first one that's found, don't use all found paths.
• If still no fortune is found, try using the original name as a path relative to the current directory.

Does this look ok?

---

Remaining work:

• Localisation support
• Move XDGFORTDIR and XDGOFFDIR to CMake
• Support for probabilities for the all argument e.g. fortune 9% all

[shlomif]

Hi @ralismark !

1. please keep debugprint().
2. The changes are far too intrusive. please split them into several single-purpose-changes pullreqs.

[ralismark]

Will do! I'll split this up into a few smaller standalone PRs.

[shlomif]

On Thu, 02 Mar 2023 02:22:04 -0800 Temmie Yao ***@***.***> wrote: Will do! I'll split this up into a few smaller standalone PRs.

thanks!

…

-- Shlomi Fish https://www.shlomifish.org/ https://github.com/shlomif/Freenode-programming-channel-FAQ If Emma Watson and Arnold Schwarzenegger were locked in a room alone, only Emma would come out alive. After she would break the door open. — https://www.shlomifish.org/humour/bits/facts/Emma-Watson/ Please reply to list if it's a mailing list post - https://shlom.in/reply .

[shlomif]

Per my earlier comments, I am closing this pullreq.