feat: add %php.bin% placeholder for hooks and scripts #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 36 36
Lines 744 744
=======================================
Hits 717 717
Misses 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for a %php.bin% placeholder in hook commands and one-time task scripts, which gets replaced with the actual PHP binary path to ensure the correct PHP version is used when multiple versions are available on a server.
Key Changes
- Implements a
replaceVariables()method inProcessHelperthat substitutes%php.bin%withPHP_BINARY - Integrates the placeholder replacement into the
runAndTail()method - Adds comprehensive test coverage for the new placeholder functionality
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Helper/ProcessHelper.php | Adds the replaceVariables() method and integrates it into runAndTail() to replace %php.bin% placeholder with the actual PHP binary path |
| tests/Helper/ProcessHelperTest.php | Adds test case to verify the %php.bin% placeholder is correctly replaced with PHP_BINARY in shell commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds support for a %php.bin% placeholder in hook commands and one-time task scripts. This placeholder is replaced with PHP_BINARY, ensuring the correct PHP version is used when multiple PHP versions are available on the server. Closes #63 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
shyim
force-pushed
the
feat/php-bin-placeholder
branch
from
0a047e7 to
0fab8ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a %php.bin% placeholder in hook commands and one-time task scripts. This placeholder is replaced with PHP_BINARY, ensuring the correct PHP version is used when multiple PHP versions are available on the server.
Closes #63
🤖 Generated with Claude Code