Refactor/tell a friend

[aragon999]

1. Why is this change necessary?

I wanted to remove occurrences where \sSystem is used, and found the Tellafriend controller. I refactored a bit and thereby removed the usage of \sSystem.

While at it, I noticed that there is an unused parameter in \sArticles::sGetPromotionById, which I therefore deprecated. I was not sure where I should document this deprecation.

Furthermore I am not sure, if the Tellafriend functionality should be removed (and therefore deprecated) altogether. As the mails probably will be categorized as spam anyways.
Before adding a test for this controller, I would rather remove it :-)

2. What does this change do, exactly?

See above.

3. Describe each step to reproduce the issue or behaviour.

See above.

4. Please link to the relevant issues (if any).

-

5. Which documentation changes (if any) need to be made because of this PR?

-

6. Checklist

• I have written tests and verified that they fail without my change
• I have squashed any insignificant commits
• This change has comments for package types, values, functions, and non-obvious lines of code
• I have read the contribution requirements and fulfil them.

[mitelg]

hey @aragon999

thanks for your PR 👍

new deprecations should be documented here: https://github.com/shopware5/shopware/blob/5.7/UPGRADE-5.7.md (under the 5.7.19 section)

IMO the whole tell-a-friend thing could be removed with 5.8 🤷‍♂️
I don't think this is a feature which is still used nowadays. so we could just leave the controller as it is (to make sure, we do not break anything unintentionally 😁 ) and deprecate the whole stuff, including templates and configs and so on.

[mitelg]

hey @aragon999 any progress here?

[mitelg]

Hey @aragon999

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.

For more information about our contribution guidelines, see https://github.com/shopware5/shopware/wiki/Contribute