Add trackSql action to handle generated sql and params #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysa23
suggested changes
Jan 25, 2018
| } | ||
|
|
||
| public static long Count<T>(this IDbConnection connection, Action<IRestrictable<T>> restrictions = null) | ||
| public static long Count<T>(this IDbConnection connection, Action<IRestrictable<T>> restrictions = null, Action<string> trackSql = null) |
Contributor
There was a problem hiding this comment.
Lets use an object instead of string + list of obj - it will enable us to extend it later without breaking the contract
| var parameters = new List<object>(); | ||
| var sql = countByQuery.GetSql(restrictions, parameters); | ||
|
|
||
| trackSql?.Invoke(sql); |
ysa23
reviewed
Jan 25, 2018
| private static IEnumerable<T> Run<T>(IDbConnection connection, string sql, List<object> parameters, IEnumerable<Property> properties, Action<SqlDescriptor> trackSql = null) | ||
| where T : class, new() | ||
| { | ||
| trackSql?.Invoke(new SqlDescriptor(sql, parameters)); |
Contributor
There was a problem hiding this comment.
extract to method and add try-catch to invocation - since this is an artifact and should not prevent the query to run
ysa23
approved these changes
Jan 25, 2018
Contributor
ysa23
left a comment
ysa23
left a comment
There was a problem hiding this comment.
Please update the minor version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I've added an optional
Action<string, IList<object>> trackSql = nullargument to theQueryExtmethodsTBD - tests.