Query logging #7
Conversation
ysa23
left a comment
ysa23
left a comment
There was a problem hiding this comment.
Please add an integration test that makes sure you get the right parameters upon query
| { | ||
| public readonly string Query; | ||
| public readonly string[] Parameters; | ||
| public readonly double MiliSeconds; |
There was a problem hiding this comment.
This should be long not double
|
|
||
| namespace OhioBox.Moranbernate.Logging | ||
| { | ||
| public static class QueryLoggingRepo |
There was a problem hiding this comment.
This class should be internal
| { | ||
| public static void Initialize(Assembly[] assemblies, IQueryLogger[] queryLoggers) | ||
| { | ||
| MappingRepoDictionary.InitializeAssemblies(assemblies); |
There was a problem hiding this comment.
Lets upgrade the major version - deprecating MappingRepoDictionary.InitializeAssemblies as public method and replace it with the initializer
| { | ||
| public class MoranbernateInitializer | ||
| { | ||
| public static void Initialize(Assembly[] assemblies, IQueryLogger[] queryLoggers) |
There was a problem hiding this comment.
Since query loggers are optional, give the parameter a default value
| { | ||
| public class MoranbernateInitializer | ||
| { | ||
| public static void Initialize(Assembly[] assemblies, IQueryLogger[] queryLoggers) |
There was a problem hiding this comment.
If you want, you can make it fluent:
new MoranbernateInitializer()
.AddAssemblies(...)
.AddLogger(...)
|
|
||
| namespace OhioBox.Moranbernate.Logging | ||
| { | ||
| public static class QueryLoggingRepo |
| public interface IQueryLogger | ||
| { | ||
| void LogFailedQuery(QueryPerformanceLog queryLog, Exception exception); | ||
| void LogSuccesfulQuery(QueryPerformanceLog queryLog); |
| public class QueryPerformanceLog | ||
| { | ||
| public readonly string Query; | ||
| public readonly string[] Parameters; |
There was a problem hiding this comment.
This should be an array of IDbParameter - so you don't need to do any work to get and also it will give more freedom to the logger to do whatever it needs
2 participants
No description provided.