Skip to content

Commit

Permalink
chore(shorebird_cli): use Flutter style TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
felangel committed Feb 14, 2025
1 parent 13b1041 commit c89089d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class LinuxBundleDiffer extends ArchiveDiffer {

@override
bool isNativeFilePath(String filePath) {
// TODO: implement isNativeFilePath
// TODO(bryanoltman): implement isNativeFilePath
return false;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,9 @@ class ArtifactBuilder {
);
}

// TODO(https://github.com/shorebirdtech/shorebird/issues/2855): this is
// not treated as an error by Flutter, we should not throw here.
// TODO(bryanoltman): this is not treated as an error by Flutter.
// We should not throw here, see:
// https://github.com/shorebirdtech/shorebird/issues/2855
if (stderr.contains('Encountered error while creating the IPA')) {
throw ArtifactBuildException(
'Failed to build',
Expand Down

0 comments on commit c89089d

Please sign in to comment.