Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): increase timeout to improve stability #2923

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

felangel
Copy link
Contributor

Description

  • tests(e2e): increase timeout to improve stability (5 minutes is not enough time to allow the integration test to finish reliably).

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

@felangel felangel self-assigned this Feb 24, 2025
@felangel felangel changed the title tests(e2e): increase timeout to improve stability test(e2e): increase timeout to improve stability Feb 24, 2025
@eseidel
Copy link
Contributor

eseidel commented Feb 24, 2025

Do we need to add fancier machines or otherwise optimize the test?

@felangel
Copy link
Contributor Author

Do we need to add fancier machines or otherwise optimize the test?

We can't use our custom runners since this is a public repo and our tests are pretty simple. The bottleneck is mostly running shorebird release and shorebird patch (e.g. flutter build). We could add some caching to speed things up but doing this for now just as a way to hopefully reduce the number of timeouts in our e2e.

@felangel felangel merged commit 4ebf074 into main Feb 24, 2025
4 of 10 checks passed
@felangel felangel deleted the tests/increase-e2e-timeout branch February 24, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants