refactor: minor adjustments and add unit tests

shorebirdtech · Feb 7, 2025 · 9f11315 · 9f11315
1 parent ad1b3f5
commit 9f11315
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/shorebird_code_push/lib/src/shorebird_updater.dart b/shorebird_code_push/lib/src/shorebird_updater.dart
@@ -28,9 +28,7 @@ class ReadPatchException implements Exception {
   final String message;
 
   @override
-  String toString() {
-    return '[ShorebirdUpdater.ReadPatchException] $message';
-  }
+  String toString() => '[ShorebirdUpdater] ReadPatchException: $message';
 }
 
 /// {@template update_exception}
@@ -49,7 +47,7 @@ class UpdateException implements Exception {
 
   @override
   String toString() {
-    return '[ShorebirdUpdater.UpdateException] $message';
+    return '[ShorebirdUpdater] UpdateException: $message (${reason.name})';
   }
 }
 

diff --git a/shorebird_code_push/test/src/shorebird_updater_test.dart b/shorebird_code_push/test/src/shorebird_updater_test.dart
@@ -11,5 +11,30 @@ void main() {
         expect(ShorebirdUpdater.new, returnsNormally);
       }),
     );
+
+    group(UpdateException, () {
+      test('overrides toString', () {
+        const message = 'message';
+        const reason = UpdateFailureReason.downloadFailed;
+        const exception = UpdateException(message: message, reason: reason);
+        expect(
+          exception.toString(),
+          equals(
+            '[ShorebirdUpdater] UpdateException: $message (${reason.name})',
+          ),
+        );
+      });
+    });
+
+    group(ReadPatchException, () {
+      test('overrides toString', () {
+        const message = 'message';
+        const exception = ReadPatchException(message: message);
+        expect(
+          exception.toString(),
+          equals('[ShorebirdUpdater] ReadPatchException: $message'),
+        );
+      });
+    });
   });
 }