Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build updater with static runtime to prevent flutter engine build linking errors #254

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

bryanoltman
Copy link
Contributor

We currently do this for patch. Without this flag, the updater failed to link into the Flutter engine with the following:

...
b"LINK : warning LNK4217: symbol 'qsort' defined in 'libucrt.lib(qsort.obj)' is imported by 'updater.lib(cover.o)' in function 'COVER_ctx_init'\r\n"
b'updater.lib(std-b84ff5acd6bc244a.std.bacbcc9a321ad2c6-cgu.0.rcgu.o) : error LNK2019: unresolved external symbol __imp_GetUserProfileDirectoryW referenced in function _ZN3std3env8home_dir17h0161835f45803d72E\r\n'
b'updater.lib(zdict.o) : error LNK2019: unresolved external symbol __imp_clock referenced in function ZDICT_clockSpan\r\n'
b'updater.lib(fastcover.o) : error LNK2001: unresolved external symbol __imp_clock\r\n'
b'updater.lib(cover.o) : error LNK2001: unresolved external symbol __imp_clock\r\n'
b'updater.lib(divsufsort.o) : error LNK2019: unresolved external symbol __imp__wassert referenced in function construct_BWT\r\n'
b'.\\flutter_windows.dll : fatal error LNK1120: 3 unresolved externals\r\n'
ninja: build stopped: subcommand failed.

@bryanoltman bryanoltman enabled auto-merge (squash) December 17, 2024 21:29
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bryanoltman bryanoltman merged commit a6c761f into main Dec 17, 2024
9 checks passed
@bryanoltman bryanoltman deleted the bo/windows-cargo-config branch December 17, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants