SG-36162 Refactor __launch_app_proxy_for_project in a QThread #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
reviewed
Jan 28, 2025
barbara-darkshot
requested changes
Jan 30, 2025
julien-lang
approved these changes
Jan 31, 2025
julien-lang
approved these changes
Feb 19, 2025
eduardoChaucaGallegos
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the logic for phase 1 (update last accessed timestamp in SG) when launching of the app proxy for a project in a
QThreadBackground Task Managerso it doesn't block the UI.