KafkaSinkCluster: route DescribeTransactions requests #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1818 will not alter performanceComparing Summary
|
rukai
force-pushed
the
describe_transactions
branch
from
460d927
to
642a5e4
Compare
ronycsdu
approved these changes
Nov 17, 2024
justinweng-instaclustr
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another split message type.
It follows the same logic as AddPartitionsToTxn version > 3 message type, where we route and split by transaction id.
The integration tests are following the same pattern as DescribeGroups: https://github.com/shotover/shotover-proxy/pull/1816/files