KafkaSinkCluster: route ConsumerGroupDescribe request #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
changed the title
CodSpeed Performance ReportMerging #1826 will not alter performanceComparing Summary
|
rukai
force-pushed
the
consumer_group_describe
branch
from
e3fe14a
to
4a3ebd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remain as draft until #1825 is landed. Changes on top of #1825 are in a separate commit.
ConsumerGroupDescribe is a replacement for the existing DescribeGroups message type.
No need to add new integration tests for this PR as we are already hitting this message type in our integration tests, we have avoided implementing this message type in shotover by modifying ApiVersions responses to instruct the client that we do not support ConsumerGroupDescribe.
This PR removes the ApiVersions rewrite so that the driver will make use of ConsumerGroupDescribe and then implements routing logic for ConsumerGroupDescribe.
ConsumerGroupDescribe requests are split up by group id, like the existing routing logic for message types DeleteGroups, DescribeGroups etc.