-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prop-types + dependency updates #314
Conversation
Same goes for transformable image as lightbox: ldn0x7dc/react-native-transformable-image#30 |
Also, And the navigation experimental package needs an update: goshacmd/react-native-navigation-experimental-compat#1 |
Please merge this PR and release |
Blocked completely on RN 0.49 with React 16 as it's been removed completely. Merge would be great. |
Do you have any plans about this? I hope to be as soon as possible. |
I'd would also love to see this merged and released soon guys. |
This PR fixes the PropTypes issue for shoutem/ui, but shoutem/theme and shoutem/animation as on NPM are broken. Their github repo has the fix, but they haven't published it. Not only that, they're relying on a version of react-native-view-transformer that also has the PropTypes issue, like @JulianKingman noticed. It seems like Shoutem UI has been abandoned. Time to use something like https://github.com/robinpowered/glamorous-native. |
Can this be worked on? |
Hi guys. I'm giving |
@tquiroga same here v0.49. I wanted to use this with infinitered/ignite/ and I won't have an option to wait. Probably I'll make a pr from this to my branch and move ahead. |
@zrumenjak at least give us an update please? |
Hi everyone, first of all, we want to thank each of you for giving back so much and we want to apologize for all the headaches we caused you in the last few months. It was really stressful for us too. We are aware that this library didn't get love and care it deserves, for that we are truly sorry. TLDR: Not-so-TLDR: Thank you for reading. Best, |
It looks like most of these are already implemented, at this point it just looks like a couple dependency updates. Do you want to merge this, or just make the package updates yourself and have me close this? |
Hi @JulianKingman, we had a few of PRs with similar changes so we opted to create a clean branch and fix everything in one place, so you can close this one. Changes that were implemented in this PR too is published in version |
I created this PR to switch from React.PropTypes to the
prop-types
library for proptype validation (needed in RN 0.44+). One package I couldn't update is the shoutem fork of lightbox (https://github.com/shoutem/react-native-lightbox), which still uses proptypes (I think the original package has been updated to remove proptypes, and there's an outstanding PR onreact-native-view-transformer
to switch it over ldn0x7dc/react-native-view-transformer#13).