Skip to content

refa: admin cert command #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

jonaro00
Copy link
Member

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR refactors the admin certificate renewal system, implementing individual certificate processing with rate limiting and improved type safety.

  • Added rate limiting in /admin/src/lib.rs with 1-second delays between certificate renewals to prevent API throttling
  • Refactored /admin/src/client.rs to split certificate operations into get_old_certificates() and renew_certificate() for better control
  • Potential issue: Usage of unwrap() in /admin/src/lib.rs for async operations could cause panics on API failures

3 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile

@jonaro00 jonaro00 merged commit 82ddbce into shuttle-hq:main Feb 3, 2025
0 of 21 checks passed
@jonaro00 jonaro00 deleted the refa-admin-cert branch February 3, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant