Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow --no-follow and --raw on redeploy #1973

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonaro00
Copy link
Member

No description provided.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR refactors deployment tracking arguments and adds consistent tracking options across deploy and redeploy commands in the Shuttle CLI.

  • Extracts --no-follow and --raw flags into new DeploymentTrackingArgs struct in cargo-shuttle/src/args.rs for better code organization
  • Adds tracking options support to redeploy command in cargo-shuttle/src/lib.rs for consistent behavior with deploy command
  • Updates deployment_redeploy function signature to handle new tracking arguments

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

cargo-shuttle/src/args.rs Show resolved Hide resolved
cargo-shuttle/src/args.rs Show resolved Hide resolved
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR extends the deployment tracking functionality by adding --no-follow and --raw flags to the stop command, completing the consistent implementation across all deployment-related operations.

  • Added DeploymentTrackingArgs to the Stop command in cargo-shuttle/src/args.rs for tracking flag support
  • Updated stop method in cargo-shuttle/src/lib.rs to handle tracking arguments and early return when no_follow is true
  • Modified documentation to use more generic "operation begins" wording instead of "deployment begins" to reflect broader usage

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants